From 632ef284638088cb7fb2d07b04a5b00b62d866a0 Mon Sep 17 00:00:00 2001 From: Stefan Kalkowski Date: Mon, 29 May 2017 14:52:24 +0200 Subject: [PATCH] os: removal of deprecated os/config.h (fix #2431) --- repos/base-nova/src/test/platform/target.mk | 2 +- repos/base/mk/base-libs.mk | 2 +- repos/dde_bsd/src/test/audio_in/target.mk | 2 +- repos/dde_linux/lib/mk/usb.inc | 2 +- .../src/server/rump_cgd/block_driver.h | 9 +- repos/dde_rump/src/server/rump_cgd/cgd.cc | 28 ++-- repos/dde_rump/src/server/rump_cgd/cgd.h | 4 +- repos/dde_rump/src/server/rump_cgd/main.cc | 13 +- .../src/server/liquid_framebuffer/target.mk | 2 +- repos/gems/src/app/cpu_load_display/target.mk | 2 +- repos/gems/src/app/mixer_gui_qt/main.cpp | 43 +++--- .../gems/src/app/mixer_gui_qt/main_window.cpp | 8 +- repos/gems/src/app/mixer_gui_qt/target.mk | 2 +- repos/gems/src/app/themed_decorator/config.h | 8 +- repos/gems/src/app/themed_decorator/main.cc | 2 +- repos/libports/lib/mk/libc_lwip_nic_dhcp.mk | 2 +- repos/libports/run/python.run | 2 +- .../src/lib/libc_lwip_nic_dhcp/init.cc | 129 ------------------ .../src/lib/libc_lwip_nic_dhcp/plugin.cc | 127 ++++++++++++++++- .../src/lib/sdl/audio/SDL_genodeaudio.cc | 14 +- repos/libports/src/server/ffat_fs/main.cc | 12 +- .../src/server/fuse_fs/exfat/target.mk | 2 +- .../src/server/fuse_fs/ext2/target.mk | 2 +- .../src/server/fuse_fs/fuse_fs_main.cc | 60 ++++---- .../src/server/fuse_fs/ntfs-3g/target.mk | 2 +- .../libports/src/test/lwip/http_clnt/main.cc | 104 +++++--------- .../src/test/lwip/http_srv_static/main.cc | 116 ++++++---------- .../src/test/lwip/http_srv_static/target.mk | 2 +- repos/libports/src/test/python/main.cc | 34 +---- repos/os/include/os/config.h | 72 ---------- repos/os/include/os/session_policy.h | 23 +--- repos/os/lib/mk/config.mk | 3 - repos/os/lib/mk/spec/imx53/tz_vmm.inc | 2 +- .../drivers/framebuffer/spec/omap4/target.mk | 2 +- repos/os/src/drivers/nic/spec/gem/target.mk | 2 +- repos/os/src/drivers/nic/spec/linux/target.mk | 2 +- repos/os/src/drivers/uart/kdb/target.inc | 2 +- repos/os/src/lib/config/config.cc | 107 --------------- repos/os/src/server/nic_dump/target.mk | 2 +- repos/os/src/server/nic_router/target.mk | 2 +- repos/os/src/server/part_blk/target.mk | 2 +- repos/os/src/server/trace_fs/target.mk | 2 +- repos/os/src/test/audio_out/target.mk | 2 +- repos/os/src/test/audio_out_click/target.mk | 2 +- repos/os/src/test/bomb/target.mk | 2 +- repos/os/src/test/dynamic_config/target.mk | 2 +- repos/os/src/test/gpio_led/target.mk | 2 +- repos/os/src/test/gpio_signal/target.mk | 2 +- repos/os/src/test/resource_yield/target.mk | 2 +- repos/os/src/test/rom_blk/target.mk | 2 +- repos/os/src/test/trace/target.mk | 2 +- .../app/gdb_monitor/gdbserver/genode-low.cc | 9 +- repos/ports/src/app/vbox_pointer/target.mk | 2 +- .../test/gdb_monitor_target_config/main.cc | 21 ++- .../test/gdb_monitor_target_config/target.mk | 2 +- repos/ports/src/test/vbox_pointer/target.mk | 2 +- 56 files changed, 354 insertions(+), 660 deletions(-) delete mode 100644 repos/libports/src/lib/libc_lwip_nic_dhcp/init.cc delete mode 100644 repos/os/include/os/config.h delete mode 100644 repos/os/lib/mk/config.mk delete mode 100644 repos/os/src/lib/config/config.cc diff --git a/repos/base-nova/src/test/platform/target.mk b/repos/base-nova/src/test/platform/target.mk index 2901f3975..15c3c49bb 100644 --- a/repos/base-nova/src/test/platform/target.mk +++ b/repos/base-nova/src/test/platform/target.mk @@ -1,3 +1,3 @@ TARGET = test-platform SRC_CC = main.cc ipc.cc -LIBS = base-nova config +LIBS = base-nova diff --git a/repos/base/mk/base-libs.mk b/repos/base/mk/base-libs.mk index 5438514f3..addace958 100644 --- a/repos/base/mk/base-libs.mk +++ b/repos/base/mk/base-libs.mk @@ -4,7 +4,7 @@ # These static libraries are filtered out when linking dynamically linked # binaries. # -BASE_LIBS += cxx timed_semaphore alarm config +BASE_LIBS += cxx timed_semaphore alarm # # Name of Genode's dynamic linker diff --git a/repos/dde_bsd/src/test/audio_in/target.mk b/repos/dde_bsd/src/test/audio_in/target.mk index 925bf4b82..195fcc4e8 100644 --- a/repos/dde_bsd/src/test/audio_in/target.mk +++ b/repos/dde_bsd/src/test/audio_in/target.mk @@ -1,3 +1,3 @@ TARGET = test-audio_in SRC_CC = main.cc -LIBS = base config +LIBS = base diff --git a/repos/dde_linux/lib/mk/usb.inc b/repos/dde_linux/lib/mk/usb.inc index 5cf6cc723..c6a65f3dc 100644 --- a/repos/dde_linux/lib/mk/usb.inc +++ b/repos/dde_linux/lib/mk/usb.inc @@ -1,7 +1,7 @@ LIB_DIR = $(REP_DIR)/src/lib/usb LIB_INC_DIR = $(LIB_DIR)/include -LIBS += usb_include lx_kit_setjmp config +LIBS += usb_include lx_kit_setjmp SRC_CC += main.cc lx_emul.cc storage.cc \ input_component.cc evdev.cc nic.cc raw.cc SRC_C += dummies.c scsi.c raw_driver.c diff --git a/repos/dde_rump/src/server/rump_cgd/block_driver.h b/repos/dde_rump/src/server/rump_cgd/block_driver.h index c4641f102..538882029 100644 --- a/repos/dde_rump/src/server/rump_cgd/block_driver.h +++ b/repos/dde_rump/src/server/rump_cgd/block_driver.h @@ -28,6 +28,7 @@ class Driver : public Block::Driver { private: + Genode::Heap &_heap; Block::Session::Operations _ops; Genode::size_t _blk_sz; Block::sector_t _blk_cnt; @@ -37,13 +38,13 @@ class Driver : public Block::Driver public: - Driver(Genode::Entrypoint &ep, Genode::Ram_session &ram) + Driver(Genode::Env &env, Genode::Heap &heap) : - Block::Driver(ram), + Block::Driver(env.ram()), _heap(heap), _blk_sz(0), _blk_cnt(0), _cgd_device(0) { try { - _cgd_device = Cgd::init(Genode::env()->heap(), ep); + _cgd_device = Cgd::init(_heap, env); } catch (...) { Genode::error("could not initialize cgd device."); throw Genode::Service_denied(); @@ -62,7 +63,7 @@ class Driver : public Block::Driver ~Driver() { - Cgd::deinit(Genode::env()->heap(), _cgd_device); + Cgd::deinit(_heap, _cgd_device); } bool _range_valid(Block::sector_t num, Genode::size_t count) diff --git a/repos/dde_rump/src/server/rump_cgd/cgd.cc b/repos/dde_rump/src/server/rump_cgd/cgd.cc index 9e5e8b5c5..1354e3c7d 100644 --- a/repos/dde_rump/src/server/rump_cgd/cgd.cc +++ b/repos/dde_rump/src/server/rump_cgd/cgd.cc @@ -12,7 +12,7 @@ */ /* Genode includes */ -#include +#include /* repo includes */ #include @@ -164,9 +164,9 @@ namespace Cgd { VALID_ENCODED_KEY_LEN = 48, /* length of 256Bit key */ }; - Genode::Config &_cfg; - Action _action; - Params *_params; + Genode::Attached_rom_dataspace _cfg; + Action _action; + Params *_params; /** * Get action from config attribute @@ -177,8 +177,8 @@ namespace Cgd { { char action_val[ACTION_VALUE_LEN]; - if (_cfg.xml_node().has_attribute("action")) - _cfg.xml_node().attribute("action").value(action_val, sizeof (action_val)); + if (_cfg.xml().has_attribute("action")) + _cfg.xml().attribute("action").value(action_val, sizeof (action_val)); else return ACTION_INVALID; @@ -224,8 +224,8 @@ namespace Cgd { */ void _parse_config() { - if (_cfg.xml_node().has_sub_node("params")) { - Genode::Xml_node pnode = _cfg.xml_node().sub_node("params"); + if (_cfg.xml().has_sub_node("params")) { + Genode::Xml_node pnode = _cfg.xml().sub_node("params"); char method_val[4]; pnode.sub_node("method").value(method_val, sizeof (method_val)); @@ -270,9 +270,9 @@ namespace Cgd { public: - Config() + Config(Genode::Env &env) : - _cfg(*Genode::config()), + _cfg(env, "config"), _action(_get_action()), _params(0) { @@ -444,7 +444,7 @@ Cgd::Device *Cgd::Device::configure(Genode::Allocator *alloc, Cgd::Params const /** * Initialize a new Cgd::Device */ -Cgd::Device *Cgd::init(Genode::Allocator *alloc, Genode::Entrypoint &ep) +Cgd::Device *Cgd::init(Genode::Allocator &alloc, Genode::Env &env) { /* start rumpkernel */ rump_init(); @@ -456,7 +456,7 @@ Cgd::Device *Cgd::init(Genode::Allocator *alloc, Genode::Entrypoint &ep) throw Genode::Exception(); } - Cgd::Config cfg; + Cgd::Config cfg(env); Cgd::Config::Action action = cfg.action(); @@ -469,7 +469,7 @@ Cgd::Device *Cgd::init(Genode::Allocator *alloc, Genode::Entrypoint &ep) if (!p) throw Genode::Exception(); - cgd_dev = Cgd::Device::configure(alloc, p, GENODE_DEVICE); + cgd_dev = Cgd::Device::configure(&alloc, p, GENODE_DEVICE); break; } @@ -495,7 +495,7 @@ Cgd::Device *Cgd::init(Genode::Allocator *alloc, Genode::Entrypoint &ep) /** * Deinitialize a Cgd::Device */ -void Cgd::deinit(Genode::Allocator *alloc, Cgd::Device *dev) +void Cgd::deinit(Genode::Allocator &alloc, Cgd::Device *dev) { destroy(alloc, dev); diff --git a/repos/dde_rump/src/server/rump_cgd/cgd.h b/repos/dde_rump/src/server/rump_cgd/cgd.h index d0ee07c0c..f5d198507 100644 --- a/repos/dde_rump/src/server/rump_cgd/cgd.h +++ b/repos/dde_rump/src/server/rump_cgd/cgd.h @@ -51,8 +51,8 @@ namespace Cgd { }; - Device *init(Genode::Allocator *alloc, Genode::Entrypoint &ep); - void deinit(Genode::Allocator *alloc, Device *dev); + Device *init(Genode::Allocator &alloc, Genode::Env &env); + void deinit(Genode::Allocator &alloc, Device *dev); } #endif /* _CGD_H_ */ diff --git a/repos/dde_rump/src/server/rump_cgd/main.cc b/repos/dde_rump/src/server/rump_cgd/main.cc index 38b1fb94f..9079c7f5a 100644 --- a/repos/dde_rump/src/server/rump_cgd/main.cc +++ b/repos/dde_rump/src/server/rump_cgd/main.cc @@ -27,20 +27,19 @@ struct Main struct Factory : Block::Driver_factory { - Genode::Entrypoint &ep; - Genode::Ram_session &ram; - Genode::Heap &heap; + Genode::Env &env; + Genode::Heap &heap; - Factory(Genode::Entrypoint &ep, Genode::Ram_session &ram, Genode::Heap &heap) - : ep(ep), ram(ram), heap(heap) { } + Factory(Genode::Env &env, Genode::Heap &heap) + : env(env), heap(heap) { } Block::Driver *create() { - return new (&heap) Driver(ep, ram); } + return new (&heap) Driver(env, heap); } void destroy(Block::Driver *driver) { Genode::destroy(&heap, driver); } - } factory { env.ep(), env.ram(), heap }; + } factory { env, heap }; Block::Root root { env.ep(), heap, env.rm(), factory }; diff --git a/repos/demo/src/server/liquid_framebuffer/target.mk b/repos/demo/src/server/liquid_framebuffer/target.mk index abb0a602d..f5777fab7 100644 --- a/repos/demo/src/server/liquid_framebuffer/target.mk +++ b/repos/demo/src/server/liquid_framebuffer/target.mk @@ -1,5 +1,5 @@ TARGET = liquid_fb -LIBS = scout_widgets config +LIBS = scout_widgets SRC_CC = main.cc services.cc INC_DIR += $(REP_DIR)/src/app/scout \ $(REP_DIR)/src/server/framebuffer/sdl diff --git a/repos/gems/src/app/cpu_load_display/target.mk b/repos/gems/src/app/cpu_load_display/target.mk index bec9c28d5..31797990e 100644 --- a/repos/gems/src/app/cpu_load_display/target.mk +++ b/repos/gems/src/app/cpu_load_display/target.mk @@ -1,4 +1,4 @@ TARGET = cpu_load_display SRC_CC = main.cc -LIBS = base config +LIBS = base INC_DIR += $(PRG_DIR) diff --git a/repos/gems/src/app/mixer_gui_qt/main.cpp b/repos/gems/src/app/mixer_gui_qt/main.cpp index 6ee4f02af..0b7226fd1 100644 --- a/repos/gems/src/app/mixer_gui_qt/main.cpp +++ b/repos/gems/src/app/mixer_gui_qt/main.cpp @@ -92,26 +92,33 @@ static inline void load_stylesheet() } -int main(int argc, char *argv[]) +void Libc::Component::construct(Libc::Env &env) { - Report_thread *report_thread; - try { report_thread = new Report_thread(); } - catch (...) { + Libc::with_libc([&] { + initialize_qpa_plugin(env); + + int argc = 1; + char const *argv[] = { "mixer_gui_qt", 0 }; + + Report_thread *report_thread; + try { report_thread = new Report_thread(); } + catch (...) { Genode::error("Could not create Report_thread"); return -1; + } + + QApplication app(argc, argv); + + load_stylesheet(); + + QMember main_window(env); + main_window->show(); + + report_thread->connect_window(main_window); + report_thread->start(); + + app.connect(&app, SIGNAL(lastWindowClosed()), SLOT(quit())); + + exit(app.exec()); } - - QApplication app(argc, argv); - - load_stylesheet(); - - QMember main_window; - main_window->show(); - - report_thread->connect_window(main_window); - report_thread->start(); - - app.connect(&app, SIGNAL(lastWindowClosed()), SLOT(quit())); - - return app.exec(); } diff --git a/repos/gems/src/app/mixer_gui_qt/main_window.cpp b/repos/gems/src/app/mixer_gui_qt/main_window.cpp index 5890284da..6419c580c 100644 --- a/repos/gems/src/app/mixer_gui_qt/main_window.cpp +++ b/repos/gems/src/app/mixer_gui_qt/main_window.cpp @@ -15,7 +15,6 @@ #include #include #include -#include #include #include @@ -434,7 +433,7 @@ void Main_window::report_changed(void *l, void const *p) } -Main_window::Main_window() +Main_window::Main_window(Libc::Env &env) : _default_out_volume(0), _default_volume(0), @@ -445,13 +444,14 @@ Main_window::Main_window() using namespace Genode; + Attached_rom_dataspace config(env, "config"); try { - Xml_node config_node = config()->xml_node(); + Xml_node config_node = config.xml(); _verbose = config_node.attribute("verbose").has_value("yes"); } catch (...) { _verbose = false; } try { - Xml_node node = config()->xml_node().sub_node("default"); + Xml_node node = config.xml().sub_node("default"); _default_out_volume = node.attribute_value("out_volume", 0); _default_volume = node.attribute_value("volume", 0); _default_muted = node.attribute_value("muted", 1); diff --git a/repos/gems/src/app/mixer_gui_qt/target.mk b/repos/gems/src/app/mixer_gui_qt/target.mk index 50c13e699..927451da2 100644 --- a/repos/gems/src/app/mixer_gui_qt/target.mk +++ b/repos/gems/src/app/mixer_gui_qt/target.mk @@ -8,4 +8,4 @@ include $(QT5_REP_DIR)/src/app/qt5/tmpl/target_final.inc main_window.o: main_window.moc -LIBS += config qoost qt5_component +LIBS += qoost qt5_gui qt5_widgets qt5_core libc diff --git a/repos/gems/src/app/themed_decorator/config.h b/repos/gems/src/app/themed_decorator/config.h index ca37ca57a..cf0c8401a 100644 --- a/repos/gems/src/app/themed_decorator/config.h +++ b/repos/gems/src/app/themed_decorator/config.h @@ -31,8 +31,14 @@ namespace Decorator { class Decorator::Config { + private: + + Genode::Xml_node _config; + public: + Config(Genode::Xml_node node) : _config(node) {} + /** * Return the base color of the window with the specified title */ @@ -41,7 +47,7 @@ class Decorator::Config Color result(0, 0, 0); try { - Genode::Session_policy policy(title); + Genode::Session_policy policy(title, _config); result = policy.attribute_value("color", result); } catch (Genode::Session_policy::No_policy_defined) { } diff --git a/repos/gems/src/app/themed_decorator/main.cc b/repos/gems/src/app/themed_decorator/main.cc index 8e97afafc..75f85caec 100644 --- a/repos/gems/src/app/themed_decorator/main.cc +++ b/repos/gems/src/app/themed_decorator/main.cc @@ -101,7 +101,7 @@ struct Decorator::Main : Window_factory_base Attached_rom_dataspace _config { _env, "config" }; - Config _decorator_config; + Config _decorator_config { _config.xml() }; void _handle_config(); diff --git a/repos/libports/lib/mk/libc_lwip_nic_dhcp.mk b/repos/libports/lib/mk/libc_lwip_nic_dhcp.mk index 5b8c6e3a4..cf82d8108 100644 --- a/repos/libports/lib/mk/libc_lwip_nic_dhcp.mk +++ b/repos/libports/lib/mk/libc_lwip_nic_dhcp.mk @@ -1,4 +1,4 @@ -SRC_CC = init.cc plugin.cc +SRC_CC = plugin.cc vpath %.cc $(REP_DIR)/src/lib/libc_lwip_nic_dhcp diff --git a/repos/libports/run/python.run b/repos/libports/run/python.run index 3ff37ca08..a195cfeb6 100644 --- a/repos/libports/run/python.run +++ b/repos/libports/run/python.run @@ -39,7 +39,6 @@ set config { -