From 42c21e45823bc9bcc64888f75704a211c180c9a1 Mon Sep 17 00:00:00 2001 From: Alexandre Bique Date: Wed, 15 Feb 2012 06:27:36 +0100 Subject: [PATCH] Console: don't use buf for '-' and '0' padding As buf is not sized depending on the padding, if a huge padding is put in buf then we could see an overflow. --- base/src/base/console/console.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/base/src/base/console/console.cc b/base/src/base/console/console.cc index f1388d8e3..cd9313fb1 100644 --- a/base/src/base/console/console.cc +++ b/base/src/base/console/console.cc @@ -188,7 +188,7 @@ void Console::_out_signed(T value, unsigned base) /* add sign to buffer for negative values */ if (neg) - buf[i++] = '-'; + _out_char('-'); /* output buffer in reverse order */ for (; i--; ) @@ -223,7 +223,7 @@ void Console::_out_unsigned(T value, unsigned base, int pad) /* add padding zeros */ for (; pad-- > 0; ) - buf[i++] = ascii(0); + _out_char(ascii(0)); /* output buffer in reverse order */ for (; i--; )