From 411601ebd1f68e94dfd53d2fd3d427b58d2915e2 Mon Sep 17 00:00:00 2001 From: Martin Stein Date: Wed, 8 Nov 2017 20:33:50 +0100 Subject: [PATCH] input_filter: add missing virtual Source::~Source Previously the destructors of classes derived from Source were not called when destructing a Source because Source missed the declaration of a virtual destructor. This caused at least problems when reconstructing a Chargen_source with its Chargen_repeater that includes a One_shot_timeout. In this case, the members of the Alarm behind the timeout were not reset and the next time beeing used the Alarm appeared to be still active which wasn't true. Fixes #2570 --- repos/os/src/server/input_filter/source.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/repos/os/src/server/input_filter/source.h b/repos/os/src/server/input_filter/source.h index c0ef40ea7..f9df447a8 100644 --- a/repos/os/src/server/input_filter/source.h +++ b/repos/os/src/server/input_filter/source.h @@ -36,6 +36,8 @@ class Input_filter::Source Source(Registry &owner) : _owner_elem(owner, *this) { } + virtual ~Source() { } + static bool input_node(Xml_node node) { return node.type() == "input"