From 101b868cd4bec3848f3a3a34e2bf17eada2a92c3 Mon Sep 17 00:00:00 2001 From: Norman Feske Date: Fri, 4 Dec 2015 12:27:23 +0100 Subject: [PATCH] gems: prevent invalid Nitpicker_buffer objects This patch ensures that we never request a zero-sized virtual framebuffer from nitpicker even when instantiating the object with zero width or height. It therebu removes the burden of handling the resulting invalid framebuffer dataspace from the user of the Nitpicker_buffer utility. --- repos/gems/include/gems/nitpicker_buffer.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/repos/gems/include/gems/nitpicker_buffer.h b/repos/gems/include/gems/nitpicker_buffer.h index 4e7db0a24..27eec5ab4 100644 --- a/repos/gems/include/gems/nitpicker_buffer.h +++ b/repos/gems/include/gems/nitpicker_buffer.h @@ -86,7 +86,8 @@ struct Nitpicker_buffer Genode::Ram_session &ram) : ram(ram), nitpicker(nitpicker), - mode(size.w(), size.h(), nitpicker.mode().format()) + mode(Genode::max(1UL, size.w()), Genode::max(1UL, size.h()), + nitpicker.mode().format()) { } /**