genode/repos/base/include/base/rpc_args.h

135 lines
2.8 KiB
C
Raw Normal View History

2011-12-22 16:19:25 +01:00
/*
* \brief Helpers for non-ordinary RPC arguments
* \author Norman Feske
* \date 2011-04-06
*/
/*
* Copyright (C) 2011-2017 Genode Labs GmbH
2011-12-22 16:19:25 +01:00
*
* This file is part of the Genode OS framework, which is distributed
* under the terms of the GNU Affero General Public License version 3.
2011-12-22 16:19:25 +01:00
*/
#ifndef _INCLUDE__BASE__RPC_ARGS_H_
#define _INCLUDE__BASE__RPC_ARGS_H_
#include <util/string.h>
#include <base/stdint.h>
namespace Genode {
class Rpc_in_buffer_base;
template <size_t> class Rpc_in_buffer;
2011-12-22 16:19:25 +01:00
}
/**
* Base class of 'Rpc_in_buffer'
*/
class Genode::Rpc_in_buffer_base
{
protected:
const char *_base;
size_t _size;
/**
* Construct buffer from null-terminated string
*/
explicit Rpc_in_buffer_base(const char *str)
: _base(str), _size(strlen(str) + 1) { }
/**
* Construct an empty buffer by default
*/
Rpc_in_buffer_base(): _base(0), _size(0) { }
public:
/**
* Construct buffer
*/
Rpc_in_buffer_base(const char *base, size_t size)
: _base(base), _size(size) { }
const char *base() const { return _base; }
size_t size() const { return _size; }
};
/**
* Buffer with size constrain
*/
template <Genode::size_t MAX>
class Genode::Rpc_in_buffer : public Rpc_in_buffer_base
{
private:
/*
* This member is only there to pump up the size of the object such
* that 'sizeof()' returns the maximum buffer size when queried by
* the RPC framework.
*/
char _balloon[MAX];
public:
enum { MAX_SIZE = MAX };
/**
* Construct buffer
*/
Rpc_in_buffer(const char *base, size_t size)
: Rpc_in_buffer_base(base, min(size, (size_t)MAX_SIZE)) { }
/**
* Construct buffer from null-terminated string
*/
Rpc_in_buffer(const char *str) : Rpc_in_buffer_base(str)
{
if (_size >= MAX_SIZE)
_size = MAX_SIZE;
}
/**
* Default constructor creates invalid buffer
*/
Rpc_in_buffer() { }
Follow practices suggested by "Effective C++" The patch adjust the code of the base, base-<kernel>, and os repository. To adapt existing components to fix violations of the best practices suggested by "Effective C++" as reported by the -Weffc++ compiler argument. The changes follow the patterns outlined below: * A class with virtual functions can no longer publicly inherit base classed without a vtable. The inherited object may either be moved to a member variable, or inherited privately. The latter would be used for classes that inherit 'List::Element' or 'Avl_node'. In order to enable the 'List' and 'Avl_tree' to access the meta data, the 'List' must become a friend. * Instead of adding a virtual destructor to abstract base classes, we inherit the new 'Interface' class, which contains a virtual destructor. This way, single-line abstract base classes can stay as compact as they are now. The 'Interface' utility resides in base/include/util/interface.h. * With the new warnings enabled, all member variables must be explicitly initialized. Basic types may be initialized with '='. All other types are initialized with braces '{ ... }' or as class initializers. If basic types and non-basic types appear in a row, it is nice to only use the brace syntax (also for basic types) and align the braces. * If a class contains pointers as members, it must now also provide a copy constructor and assignment operator. In the most cases, one would make them private, effectively disallowing the objects to be copied. Unfortunately, this warning cannot be fixed be inheriting our existing 'Noncopyable' class (the compiler fails to detect that the inheriting class cannot be copied and still gives the error). For now, we have to manually add declarations for both the copy constructor and assignment operator as private class members. Those declarations should be prepended with a comment like this: /* * Noncopyable */ Thread(Thread const &); Thread &operator = (Thread const &); In the future, we should revisit these places and try to replace the pointers with references. In the presence of at least one reference member, the compiler would no longer implicitly generate a copy constructor. So we could remove the manual declaration. Issue #465
2017-12-21 15:42:15 +01:00
Rpc_in_buffer &operator = (Rpc_in_buffer<MAX_SIZE> const &from)
{
_base = from.base();
_size = from.size();
Follow practices suggested by "Effective C++" The patch adjust the code of the base, base-<kernel>, and os repository. To adapt existing components to fix violations of the best practices suggested by "Effective C++" as reported by the -Weffc++ compiler argument. The changes follow the patterns outlined below: * A class with virtual functions can no longer publicly inherit base classed without a vtable. The inherited object may either be moved to a member variable, or inherited privately. The latter would be used for classes that inherit 'List::Element' or 'Avl_node'. In order to enable the 'List' and 'Avl_tree' to access the meta data, the 'List' must become a friend. * Instead of adding a virtual destructor to abstract base classes, we inherit the new 'Interface' class, which contains a virtual destructor. This way, single-line abstract base classes can stay as compact as they are now. The 'Interface' utility resides in base/include/util/interface.h. * With the new warnings enabled, all member variables must be explicitly initialized. Basic types may be initialized with '='. All other types are initialized with braces '{ ... }' or as class initializers. If basic types and non-basic types appear in a row, it is nice to only use the brace syntax (also for basic types) and align the braces. * If a class contains pointers as members, it must now also provide a copy constructor and assignment operator. In the most cases, one would make them private, effectively disallowing the objects to be copied. Unfortunately, this warning cannot be fixed be inheriting our existing 'Noncopyable' class (the compiler fails to detect that the inheriting class cannot be copied and still gives the error). For now, we have to manually add declarations for both the copy constructor and assignment operator as private class members. Those declarations should be prepended with a comment like this: /* * Noncopyable */ Thread(Thread const &); Thread &operator = (Thread const &); In the future, we should revisit these places and try to replace the pointers with references. In the presence of at least one reference member, the compiler would no longer implicitly generate a copy constructor. So we could remove the manual declaration. Issue #465
2017-12-21 15:42:15 +01:00
return *this;
}
/**
* Return true if buffer contains a valid null-terminated string
*/
bool valid_string() const {
return (_size <= MAX_SIZE) && (_size > 0) && (_base[_size - 1] == '\0'); }
/**
* Return true if buffer contains a valid null-terminated string
*
* \noapi
* \deprecated use valid_string instead
*/
bool is_valid_string() const { return valid_string(); }
/**
* Return buffer content as null-terminated string
*
* \return pointer to null-terminated string
*
* The method returns an empty string if the buffer does not hold
* a valid null-terminated string. To distinguish a buffer holding
* an invalid string from a buffer holding a valid empty string,
* the function 'valid_string' can be used.
*/
char const *string() const { return valid_string() ? base() : ""; }
};
2011-12-22 16:19:25 +01:00
#endif /* _INCLUDE__BASE__RPC_ARGS_H_ */