2011-12-22 16:19:25 +01:00
|
|
|
/*
|
|
|
|
|
* \brief Core-local mapping
|
|
|
|
|
* \author Norman Feske
|
|
|
|
|
* \date 2010-02-15
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
/*
|
2017-02-20 13:23:52 +01:00
|
|
|
* Copyright (C) 2010-2017 Genode Labs GmbH
|
2011-12-22 16:19:25 +01:00
|
|
|
*
|
|
|
|
|
* This file is part of the Genode OS framework, which is distributed
|
2017-02-20 13:23:52 +01:00
|
|
|
* under the terms of the GNU Affero General Public License version 3.
|
2011-12-22 16:19:25 +01:00
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#ifndef _CORE__INCLUDE__MAP_LOCAL_H_
|
|
|
|
|
#define _CORE__INCLUDE__MAP_LOCAL_H_
|
|
|
|
|
|
|
|
|
|
/* core includes */
|
|
|
|
|
#include <platform.h>
|
|
|
|
|
#include <util.h>
|
|
|
|
|
|
|
|
|
|
/* Fiasco includes */
|
|
|
|
|
namespace Fiasco {
|
|
|
|
|
#include <l4/sys/ipc.h>
|
|
|
|
|
#include <l4/sys/syscalls.h>
|
|
|
|
|
#include <l4/sys/kdebug.h>
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
namespace Genode {
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Map page locally within core
|
|
|
|
|
*
|
|
|
|
|
* On Fiasco, all mapping originate from virtual addresses. At startup,
|
|
|
|
|
* core obtains the whole memory sigma0 in a one-to-one fashion. Hence,
|
|
|
|
|
* core-local addresses normally correspond to physical addresses.
|
|
|
|
|
*
|
|
|
|
|
* \param from_addr core-virtual source address
|
|
|
|
|
* \param to_addr core-virtual destination address
|
|
|
|
|
* \param num_pages number of pages to remap
|
|
|
|
|
*/
|
|
|
|
|
inline bool map_local(addr_t from_addr, addr_t to_addr, size_t num_pages)
|
|
|
|
|
{
|
base/core: use references instead of pointers
This patch replaces the former prominent use of pointers by references
wherever feasible. This has the following benefits:
* The contract between caller and callee becomes more obvious. When
passing a reference, the contract says that the argument cannot be
a null pointer. The caller is responsible to ensure that. Therefore,
the use of reference eliminates the need to add defensive null-pointer
checks at the callee site, which sometimes merely exist to be on the
safe side. The bottom line is that the code becomes easier to follow.
* Reference members must be initialized via an object initializer,
which promotes a programming style that avoids intermediate object-
construction states. Within core, there are still a few pointers
as member variables left though. E.g., caused by the late association
of 'Platform_thread' objects with their 'Platform_pd' objects.
* If no pointers are present as member variables, we don't need to
manually provide declarations of a private copy constructor and
an assignment operator to avoid -Weffc++ errors "class ... has
pointer data members [-Werror=effc++]".
This patch also changes a few system bindings on NOVA and Fiasco.OC,
e.g., the return value of the global 'cap_map' accessor has become a
reference. Hence, the patch touches a few places outside of core.
Fixes #3135
2019-01-24 22:00:01 +01:00
|
|
|
Fiasco::l4_threadid_t core_pager = platform_specific().core_pager().native_thread_id();
|
2011-12-22 16:19:25 +01:00
|
|
|
|
|
|
|
|
addr_t offset = 0;
|
|
|
|
|
size_t page_size = get_page_size();
|
|
|
|
|
size_t page_size_log2 = get_page_size_log2();
|
|
|
|
|
for (unsigned i = 0; i < num_pages; i++, offset += page_size) {
|
|
|
|
|
|
|
|
|
|
using namespace Fiasco;
|
|
|
|
|
|
|
|
|
|
/* perform echo request to the core pager */
|
|
|
|
|
l4_umword_t dummy = 0;
|
|
|
|
|
l4_msgdope_t ipc_result;
|
|
|
|
|
l4_fpage_t from_fpage = l4_fpage(from_addr + offset,
|
|
|
|
|
page_size_log2, true, false);
|
|
|
|
|
enum { ECHO_LOCAL_MAP_REQUEST = 0 };
|
|
|
|
|
l4_ipc_call(core_pager, L4_IPC_SHORT_MSG,
|
|
|
|
|
from_fpage.raw, /* normally page-fault addr */
|
|
|
|
|
ECHO_LOCAL_MAP_REQUEST, /* normally page-fault IP */
|
|
|
|
|
L4_IPC_MAPMSG(to_addr + offset, page_size_log2),
|
|
|
|
|
&dummy, &dummy,
|
|
|
|
|
L4_IPC_NEVER, &ipc_result);
|
|
|
|
|
|
|
|
|
|
if (L4_IPC_IS_ERROR(ipc_result)) {
|
base: avoid use of deprecated base/printf.h
Besides adapting the components to the use of base/log.h, the patch
cleans up a few base headers, i.e., it removes unused includes from
root/component.h, specifically base/heap.h and
ram_session/ram_session.h. Hence, components that relied on the implicit
inclusion of those headers have to manually include those headers now.
While adjusting the log messages, I repeatedly stumbled over the problem
that printing char * arguments is ambiguous. It is unclear whether to
print the argument as pointer or null-terminated string. To overcome
this problem, the patch introduces a new type 'Cstring' that allows the
caller to express that the argument should be handled as null-terminated
string. As a nice side effect, with this type in place, the optional len
argument of the 'String' class could be removed. Instead of supplying a
pair of (char const *, size_t), the constructor accepts a 'Cstring'.
This, in turn, clears the way let the 'String' constructor use the new
output mechanism to assemble a string from multiple arguments (and
thereby getting rid of snprintf within Genode in the near future).
To enforce the explicit resolution of the char * ambiguity, the 'char *'
overload of the 'print' function is marked as deleted.
Issue #1987
2016-07-13 19:07:09 +02:00
|
|
|
warning("could not locally remap ", Hex(from_addr), " "
|
|
|
|
|
"to ", Hex(to_addr), ", "
|
|
|
|
|
"error code is ", L4_IPC_ERROR(ipc_result));
|
2011-12-22 16:19:25 +01:00
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return true;
|
|
|
|
|
}
|
2012-10-15 22:11:56 +02:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Unmap pages locally within core
|
|
|
|
|
*
|
|
|
|
|
* \param virt core-local address
|
|
|
|
|
* \param num_pages number of pages to unmap
|
|
|
|
|
*/
|
Follow practices suggested by "Effective C++"
The patch adjust the code of the base, base-<kernel>, and os repository.
To adapt existing components to fix violations of the best practices
suggested by "Effective C++" as reported by the -Weffc++ compiler
argument. The changes follow the patterns outlined below:
* A class with virtual functions can no longer publicly inherit base
classed without a vtable. The inherited object may either be moved
to a member variable, or inherited privately. The latter would be
used for classes that inherit 'List::Element' or 'Avl_node'. In order
to enable the 'List' and 'Avl_tree' to access the meta data, the
'List' must become a friend.
* Instead of adding a virtual destructor to abstract base classes,
we inherit the new 'Interface' class, which contains a virtual
destructor. This way, single-line abstract base classes can stay
as compact as they are now. The 'Interface' utility resides in
base/include/util/interface.h.
* With the new warnings enabled, all member variables must be explicitly
initialized. Basic types may be initialized with '='. All other types
are initialized with braces '{ ... }' or as class initializers. If
basic types and non-basic types appear in a row, it is nice to only
use the brace syntax (also for basic types) and align the braces.
* If a class contains pointers as members, it must now also provide a
copy constructor and assignment operator. In the most cases, one
would make them private, effectively disallowing the objects to be
copied. Unfortunately, this warning cannot be fixed be inheriting
our existing 'Noncopyable' class (the compiler fails to detect that
the inheriting class cannot be copied and still gives the error).
For now, we have to manually add declarations for both the copy
constructor and assignment operator as private class members. Those
declarations should be prepended with a comment like this:
/*
* Noncopyable
*/
Thread(Thread const &);
Thread &operator = (Thread const &);
In the future, we should revisit these places and try to replace
the pointers with references. In the presence of at least one
reference member, the compiler would no longer implicitly generate
a copy constructor. So we could remove the manual declaration.
Issue #465
2017-12-21 15:42:15 +01:00
|
|
|
inline void unmap_local(addr_t, size_t)
|
2012-10-15 22:11:56 +02:00
|
|
|
{
|
base: avoid use of deprecated base/printf.h
Besides adapting the components to the use of base/log.h, the patch
cleans up a few base headers, i.e., it removes unused includes from
root/component.h, specifically base/heap.h and
ram_session/ram_session.h. Hence, components that relied on the implicit
inclusion of those headers have to manually include those headers now.
While adjusting the log messages, I repeatedly stumbled over the problem
that printing char * arguments is ambiguous. It is unclear whether to
print the argument as pointer or null-terminated string. To overcome
this problem, the patch introduces a new type 'Cstring' that allows the
caller to express that the argument should be handled as null-terminated
string. As a nice side effect, with this type in place, the optional len
argument of the 'String' class could be removed. Instead of supplying a
pair of (char const *, size_t), the constructor accepts a 'Cstring'.
This, in turn, clears the way let the 'String' constructor use the new
output mechanism to assemble a string from multiple arguments (and
thereby getting rid of snprintf within Genode in the near future).
To enforce the explicit resolution of the char * ambiguity, the 'char *'
overload of the 'print' function is marked as deleted.
Issue #1987
2016-07-13 19:07:09 +02:00
|
|
|
error("unmap_local() called - not implemented yet");
|
2012-10-15 22:11:56 +02:00
|
|
|
}
|
2011-12-22 16:19:25 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#endif /* _CORE__INCLUDE__MAP_LOCAL_H_ */
|
