2011-12-22 16:19:25 +01:00
|
|
|
/*
|
|
|
|
* \brief Core implementation of IRQ sessions
|
|
|
|
* \author Christian Helmuth
|
|
|
|
* \date 2007-09-13
|
|
|
|
*/
|
|
|
|
|
|
|
|
/*
|
2017-02-20 13:23:52 +01:00
|
|
|
* Copyright (C) 2007-2017 Genode Labs GmbH
|
2011-12-22 16:19:25 +01:00
|
|
|
*
|
|
|
|
* This file is part of the Genode OS framework, which is distributed
|
2017-02-20 13:23:52 +01:00
|
|
|
* under the terms of the GNU Affero General Public License version 3.
|
2011-12-22 16:19:25 +01:00
|
|
|
*/
|
|
|
|
|
|
|
|
/* Genode includes */
|
base: avoid use of deprecated base/printf.h
Besides adapting the components to the use of base/log.h, the patch
cleans up a few base headers, i.e., it removes unused includes from
root/component.h, specifically base/heap.h and
ram_session/ram_session.h. Hence, components that relied on the implicit
inclusion of those headers have to manually include those headers now.
While adjusting the log messages, I repeatedly stumbled over the problem
that printing char * arguments is ambiguous. It is unclear whether to
print the argument as pointer or null-terminated string. To overcome
this problem, the patch introduces a new type 'Cstring' that allows the
caller to express that the argument should be handled as null-terminated
string. As a nice side effect, with this type in place, the optional len
argument of the 'String' class could be removed. Instead of supplying a
pair of (char const *, size_t), the constructor accepts a 'Cstring'.
This, in turn, clears the way let the 'String' constructor use the new
output mechanism to assemble a string from multiple arguments (and
thereby getting rid of snprintf within Genode in the near future).
To enforce the explicit resolution of the char * ambiguity, the 'char *'
overload of the 'print' function is marked as deleted.
Issue #1987
2016-07-13 19:07:09 +02:00
|
|
|
#include <base/log.h>
|
2011-12-22 16:19:25 +01:00
|
|
|
#include <util/arg_string.h>
|
|
|
|
|
|
|
|
/* core includes */
|
|
|
|
#include <irq_root.h>
|
|
|
|
#include <util.h>
|
|
|
|
|
|
|
|
/* Fiasco includes */
|
|
|
|
namespace Fiasco {
|
|
|
|
#include <l4/sys/ipc.h>
|
|
|
|
#include <l4/sys/syscalls.h>
|
|
|
|
#include <l4/sys/types.h>
|
|
|
|
}
|
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
using namespace Genode;
|
2015-03-17 15:41:47 +01:00
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
bool Irq_object::_associate()
|
|
|
|
{
|
|
|
|
using namespace Fiasco;
|
2015-03-17 15:41:47 +01:00
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
int err;
|
|
|
|
l4_threadid_t irq_tid;
|
|
|
|
l4_umword_t dw0, dw1;
|
|
|
|
l4_msgdope_t result;
|
2011-12-22 16:19:25 +01:00
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
l4_make_taskid_from_irq(_irq, &irq_tid);
|
2011-12-22 16:19:25 +01:00
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
/* boost thread to IRQ priority */
|
|
|
|
enum { IRQ_PRIORITY = 0xC0 };
|
2015-03-17 15:41:47 +01:00
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
l4_sched_param_t param = {sp:{prio:IRQ_PRIORITY, small:0, state:0, time_exp:0, time_man:0}};
|
|
|
|
l4_threadid_t ext_preempter = L4_INVALID_ID;
|
|
|
|
l4_threadid_t partner = L4_INVALID_ID;
|
|
|
|
l4_sched_param_t old_param;
|
|
|
|
l4_thread_schedule(l4_myself(), param, &ext_preempter, &partner, &old_param);
|
2011-12-22 16:19:25 +01:00
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
err = l4_ipc_receive(irq_tid,
|
|
|
|
L4_IPC_SHORT_MSG, &dw0, &dw1,
|
|
|
|
L4_IPC_BOTH_TIMEOUT_0, &result);
|
2011-12-22 16:19:25 +01:00
|
|
|
|
base: avoid use of deprecated base/printf.h
Besides adapting the components to the use of base/log.h, the patch
cleans up a few base headers, i.e., it removes unused includes from
root/component.h, specifically base/heap.h and
ram_session/ram_session.h. Hence, components that relied on the implicit
inclusion of those headers have to manually include those headers now.
While adjusting the log messages, I repeatedly stumbled over the problem
that printing char * arguments is ambiguous. It is unclear whether to
print the argument as pointer or null-terminated string. To overcome
this problem, the patch introduces a new type 'Cstring' that allows the
caller to express that the argument should be handled as null-terminated
string. As a nice side effect, with this type in place, the optional len
argument of the 'String' class could be removed. Instead of supplying a
pair of (char const *, size_t), the constructor accepts a 'Cstring'.
This, in turn, clears the way let the 'String' constructor use the new
output mechanism to assemble a string from multiple arguments (and
thereby getting rid of snprintf within Genode in the near future).
To enforce the explicit resolution of the char * ambiguity, the 'char *'
overload of the 'print' function is marked as deleted.
Issue #1987
2016-07-13 19:07:09 +02:00
|
|
|
if (err != L4_IPC_RETIMEOUT) error("IRQ association failed");
|
2011-12-22 16:19:25 +01:00
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
return (err == L4_IPC_RETIMEOUT);
|
|
|
|
}
|
2011-12-22 16:19:25 +01:00
|
|
|
|
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
void Irq_object::_wait_for_irq()
|
|
|
|
{
|
|
|
|
using namespace Fiasco;
|
2011-12-22 16:19:25 +01:00
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
l4_threadid_t irq_tid;
|
|
|
|
l4_umword_t dw0=0, dw1=0;
|
|
|
|
l4_msgdope_t result;
|
2011-12-22 16:19:25 +01:00
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
l4_make_taskid_from_irq(_irq, &irq_tid);
|
2011-12-22 16:19:25 +01:00
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
do {
|
|
|
|
l4_ipc_call(irq_tid,
|
|
|
|
L4_IPC_SHORT_MSG, 0, 0,
|
|
|
|
L4_IPC_SHORT_MSG, &dw0, &dw1,
|
|
|
|
L4_IPC_NEVER, &result);
|
2011-12-22 16:19:25 +01:00
|
|
|
|
base: avoid use of deprecated base/printf.h
Besides adapting the components to the use of base/log.h, the patch
cleans up a few base headers, i.e., it removes unused includes from
root/component.h, specifically base/heap.h and
ram_session/ram_session.h. Hence, components that relied on the implicit
inclusion of those headers have to manually include those headers now.
While adjusting the log messages, I repeatedly stumbled over the problem
that printing char * arguments is ambiguous. It is unclear whether to
print the argument as pointer or null-terminated string. To overcome
this problem, the patch introduces a new type 'Cstring' that allows the
caller to express that the argument should be handled as null-terminated
string. As a nice side effect, with this type in place, the optional len
argument of the 'String' class could be removed. Instead of supplying a
pair of (char const *, size_t), the constructor accepts a 'Cstring'.
This, in turn, clears the way let the 'String' constructor use the new
output mechanism to assemble a string from multiple arguments (and
thereby getting rid of snprintf within Genode in the near future).
To enforce the explicit resolution of the char * ambiguity, the 'char *'
overload of the 'print' function is marked as deleted.
Issue #1987
2016-07-13 19:07:09 +02:00
|
|
|
if (L4_IPC_IS_ERROR(result)) error("Ipc error ", L4_IPC_ERROR(result));
|
2015-05-09 21:48:12 +02:00
|
|
|
} while (L4_IPC_IS_ERROR(result));
|
|
|
|
}
|
2015-03-17 15:41:47 +01:00
|
|
|
|
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
void Irq_object::start()
|
|
|
|
{
|
2016-05-04 12:27:17 +02:00
|
|
|
::Thread::start();
|
2020-02-18 15:29:47 +01:00
|
|
|
_sync_bootup.block();
|
2015-05-09 21:48:12 +02:00
|
|
|
}
|
2015-03-17 15:41:47 +01:00
|
|
|
|
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
void Irq_object::entry()
|
|
|
|
{
|
|
|
|
if (!_associate()) {
|
base: avoid use of deprecated base/printf.h
Besides adapting the components to the use of base/log.h, the patch
cleans up a few base headers, i.e., it removes unused includes from
root/component.h, specifically base/heap.h and
ram_session/ram_session.h. Hence, components that relied on the implicit
inclusion of those headers have to manually include those headers now.
While adjusting the log messages, I repeatedly stumbled over the problem
that printing char * arguments is ambiguous. It is unclear whether to
print the argument as pointer or null-terminated string. To overcome
this problem, the patch introduces a new type 'Cstring' that allows the
caller to express that the argument should be handled as null-terminated
string. As a nice side effect, with this type in place, the optional len
argument of the 'String' class could be removed. Instead of supplying a
pair of (char const *, size_t), the constructor accepts a 'Cstring'.
This, in turn, clears the way let the 'String' constructor use the new
output mechanism to assemble a string from multiple arguments (and
thereby getting rid of snprintf within Genode in the near future).
To enforce the explicit resolution of the char * ambiguity, the 'char *'
overload of the 'print' function is marked as deleted.
Issue #1987
2016-07-13 19:07:09 +02:00
|
|
|
error("Could not associate with IRQ ", _irq);
|
2015-05-09 21:48:12 +02:00
|
|
|
return;
|
|
|
|
}
|
2015-03-17 15:41:47 +01:00
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
/* thread is up and ready */
|
2020-02-18 15:29:47 +01:00
|
|
|
_sync_bootup.wakeup();
|
2015-03-17 15:41:47 +01:00
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
/* wait for first ack_irq */
|
2020-02-18 15:29:47 +01:00
|
|
|
_sync_ack.block();
|
2015-03-17 15:41:47 +01:00
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
while (true) {
|
2011-12-22 16:19:25 +01:00
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
_wait_for_irq();
|
2011-12-22 16:19:25 +01:00
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
if (!_sig_cap.valid())
|
|
|
|
continue;
|
2011-12-22 16:19:25 +01:00
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
Genode::Signal_transmitter(_sig_cap).submit(1);
|
2011-12-22 16:19:25 +01:00
|
|
|
|
2020-02-18 15:29:47 +01:00
|
|
|
_sync_ack.block();
|
2015-03-17 15:41:47 +01:00
|
|
|
}
|
2011-12-22 16:19:25 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
Irq_object::Irq_object(unsigned irq)
|
|
|
|
:
|
2016-05-04 12:27:17 +02:00
|
|
|
Thread_deprecated<4096>("irq"),
|
2015-05-09 21:48:12 +02:00
|
|
|
_irq(irq)
|
|
|
|
{ }
|
|
|
|
|
|
|
|
|
base/core: use references instead of pointers
This patch replaces the former prominent use of pointers by references
wherever feasible. This has the following benefits:
* The contract between caller and callee becomes more obvious. When
passing a reference, the contract says that the argument cannot be
a null pointer. The caller is responsible to ensure that. Therefore,
the use of reference eliminates the need to add defensive null-pointer
checks at the callee site, which sometimes merely exist to be on the
safe side. The bottom line is that the code becomes easier to follow.
* Reference members must be initialized via an object initializer,
which promotes a programming style that avoids intermediate object-
construction states. Within core, there are still a few pointers
as member variables left though. E.g., caused by the late association
of 'Platform_thread' objects with their 'Platform_pd' objects.
* If no pointers are present as member variables, we don't need to
manually provide declarations of a private copy constructor and
an assignment operator to avoid -Weffc++ errors "class ... has
pointer data members [-Werror=effc++]".
This patch also changes a few system bindings on NOVA and Fiasco.OC,
e.g., the return value of the global 'cap_map' accessor has become a
reference. Hence, the patch touches a few places outside of core.
Fixes #3135
2019-01-24 22:00:01 +01:00
|
|
|
Irq_session_component::Irq_session_component(Range_allocator &irq_alloc,
|
2011-12-22 16:19:25 +01:00
|
|
|
const char *args)
|
|
|
|
:
|
2015-05-09 21:48:12 +02:00
|
|
|
_irq_number(Arg_string::find_arg(args, "irq_number").long_value(-1)),
|
|
|
|
_irq_alloc(irq_alloc),
|
|
|
|
_irq_object(_irq_number)
|
2011-12-22 16:19:25 +01:00
|
|
|
{
|
2015-04-27 12:17:20 +02:00
|
|
|
long msi = Arg_string::find_arg(args, "device_config_phys").long_value(0);
|
|
|
|
if (msi)
|
Streamline exception types
This patch reduces the number of exception types by facilitating
globally defined exceptions for common usage patterns shared by most
services. In particular, RPC functions that demand a session-resource
upgrade not longer reflect this condition via a session-specific
exception but via the 'Out_of_ram' or 'Out_of_caps' types.
Furthermore, the 'Parent::Service_denied', 'Parent::Unavailable',
'Root::Invalid_args', 'Root::Unavailable', 'Service::Invalid_args',
'Service::Unavailable', and 'Local_service::Factory::Denied' types have
been replaced by the single 'Service_denied' exception type defined in
'session/session.h'.
This consolidation eases the error handling (there are fewer exceptions
to handle), alleviates the need to convert exceptions along the
session-creation call chain, and avoids possible aliasing problems
(catching the wrong type with the same name but living in a different
scope).
2017-05-07 22:03:22 +02:00
|
|
|
throw Service_denied();
|
2015-04-27 12:17:20 +02:00
|
|
|
|
base/core: use references instead of pointers
This patch replaces the former prominent use of pointers by references
wherever feasible. This has the following benefits:
* The contract between caller and callee becomes more obvious. When
passing a reference, the contract says that the argument cannot be
a null pointer. The caller is responsible to ensure that. Therefore,
the use of reference eliminates the need to add defensive null-pointer
checks at the callee site, which sometimes merely exist to be on the
safe side. The bottom line is that the code becomes easier to follow.
* Reference members must be initialized via an object initializer,
which promotes a programming style that avoids intermediate object-
construction states. Within core, there are still a few pointers
as member variables left though. E.g., caused by the late association
of 'Platform_thread' objects with their 'Platform_pd' objects.
* If no pointers are present as member variables, we don't need to
manually provide declarations of a private copy constructor and
an assignment operator to avoid -Weffc++ errors "class ... has
pointer data members [-Werror=effc++]".
This patch also changes a few system bindings on NOVA and Fiasco.OC,
e.g., the return value of the global 'cap_map' accessor has become a
reference. Hence, the patch touches a few places outside of core.
Fixes #3135
2019-01-24 22:00:01 +01:00
|
|
|
if (irq_alloc.alloc_addr(1, _irq_number).error()) {
|
Streamline exception types
This patch reduces the number of exception types by facilitating
globally defined exceptions for common usage patterns shared by most
services. In particular, RPC functions that demand a session-resource
upgrade not longer reflect this condition via a session-specific
exception but via the 'Out_of_ram' or 'Out_of_caps' types.
Furthermore, the 'Parent::Service_denied', 'Parent::Unavailable',
'Root::Invalid_args', 'Root::Unavailable', 'Service::Invalid_args',
'Service::Unavailable', and 'Local_service::Factory::Denied' types have
been replaced by the single 'Service_denied' exception type defined in
'session/session.h'.
This consolidation eases the error handling (there are fewer exceptions
to handle), alleviates the need to convert exceptions along the
session-creation call chain, and avoids possible aliasing problems
(catching the wrong type with the same name but living in a different
scope).
2017-05-07 22:03:22 +02:00
|
|
|
error("unavailable IRQ ", _irq_number, " requested");
|
|
|
|
throw Service_denied();
|
2011-12-22 16:19:25 +01:00
|
|
|
}
|
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
_irq_object.start();
|
2011-12-22 16:19:25 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
Irq_session_component::~Irq_session_component()
|
|
|
|
{
|
base: avoid use of deprecated base/printf.h
Besides adapting the components to the use of base/log.h, the patch
cleans up a few base headers, i.e., it removes unused includes from
root/component.h, specifically base/heap.h and
ram_session/ram_session.h. Hence, components that relied on the implicit
inclusion of those headers have to manually include those headers now.
While adjusting the log messages, I repeatedly stumbled over the problem
that printing char * arguments is ambiguous. It is unclear whether to
print the argument as pointer or null-terminated string. To overcome
this problem, the patch introduces a new type 'Cstring' that allows the
caller to express that the argument should be handled as null-terminated
string. As a nice side effect, with this type in place, the optional len
argument of the 'String' class could be removed. Instead of supplying a
pair of (char const *, size_t), the constructor accepts a 'Cstring'.
This, in turn, clears the way let the 'String' constructor use the new
output mechanism to assemble a string from multiple arguments (and
thereby getting rid of snprintf within Genode in the near future).
To enforce the explicit resolution of the char * ambiguity, the 'char *'
overload of the 'print' function is marked as deleted.
Issue #1987
2016-07-13 19:07:09 +02:00
|
|
|
error("Not yet implemented.");
|
2011-12-22 16:19:25 +01:00
|
|
|
}
|
|
|
|
|
2015-03-17 13:28:20 +01:00
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
void Irq_session_component::ack_irq()
|
2015-03-17 13:28:20 +01:00
|
|
|
{
|
2015-05-09 21:48:12 +02:00
|
|
|
_irq_object.ack_irq();
|
|
|
|
}
|
2015-03-17 15:41:47 +01:00
|
|
|
|
|
|
|
|
2015-05-09 21:48:12 +02:00
|
|
|
void Irq_session_component::sigh(Genode::Signal_context_capability cap)
|
|
|
|
{
|
|
|
|
_irq_object.sigh(cap);
|
2015-03-17 13:28:20 +01:00
|
|
|
}
|
2015-04-27 12:17:20 +02:00
|
|
|
|
|
|
|
|
|
|
|
Genode::Irq_session::Info Irq_session_component::info()
|
|
|
|
{
|
|
|
|
/* no MSI support */
|
Follow practices suggested by "Effective C++"
The patch adjust the code of the base, base-<kernel>, and os repository.
To adapt existing components to fix violations of the best practices
suggested by "Effective C++" as reported by the -Weffc++ compiler
argument. The changes follow the patterns outlined below:
* A class with virtual functions can no longer publicly inherit base
classed without a vtable. The inherited object may either be moved
to a member variable, or inherited privately. The latter would be
used for classes that inherit 'List::Element' or 'Avl_node'. In order
to enable the 'List' and 'Avl_tree' to access the meta data, the
'List' must become a friend.
* Instead of adding a virtual destructor to abstract base classes,
we inherit the new 'Interface' class, which contains a virtual
destructor. This way, single-line abstract base classes can stay
as compact as they are now. The 'Interface' utility resides in
base/include/util/interface.h.
* With the new warnings enabled, all member variables must be explicitly
initialized. Basic types may be initialized with '='. All other types
are initialized with braces '{ ... }' or as class initializers. If
basic types and non-basic types appear in a row, it is nice to only
use the brace syntax (also for basic types) and align the braces.
* If a class contains pointers as members, it must now also provide a
copy constructor and assignment operator. In the most cases, one
would make them private, effectively disallowing the objects to be
copied. Unfortunately, this warning cannot be fixed be inheriting
our existing 'Noncopyable' class (the compiler fails to detect that
the inheriting class cannot be copied and still gives the error).
For now, we have to manually add declarations for both the copy
constructor and assignment operator as private class members. Those
declarations should be prepended with a comment like this:
/*
* Noncopyable
*/
Thread(Thread const &);
Thread &operator = (Thread const &);
In the future, we should revisit these places and try to replace
the pointers with references. In the presence of at least one
reference member, the compiler would no longer implicitly generate
a copy constructor. So we could remove the manual declaration.
Issue #465
2017-12-21 15:42:15 +01:00
|
|
|
return { .type = Info::Type::INVALID, .address = 0, .value = 0 };
|
2015-04-27 12:17:20 +02:00
|
|
|
}
|