ehmry/genode-ehmry
ehmry/genode-ehmry
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove Post_signal_hook from Entrypoint

Browse Source 
The Post_signal_hook mechanism has been completely replaced by
Io_progress_handler and can be removed.

Ref #3132
Fix #3302
This commit is contained in:
Ehmry - 2019-04-23 14:10:49 +02:00 committed by Christian Helmuth
parent 5d4064fed4
commit d2ab699cd5
2 changed files with 0 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
repos/base/include/base/entrypoint.h
View File

@ -48,14 +48,6 @@ class Genode::Entrypoint : Noncopyable
virtual void handle_io_progress() = 0; virtual void handle_io_progress() = 0;
}; };
/**
* Functor for post signal-handler hook
*
* \deprecated
* \noapi
*/
struct Post_signal_hook : Interface { virtual void function() = 0; };
private: private:
struct Signal_proxy : Interface struct Signal_proxy : Interface
@ -118,7 +110,6 @@ class Genode::Entrypoint : Noncopyable
Genode::Lock _signal_pending_ack_lock { }; Genode::Lock _signal_pending_ack_lock { };
Io_progress_handler *_io_progress_handler { nullptr }; Io_progress_handler *_io_progress_handler { nullptr };
Post_signal_hook *_post_signal_hook { nullptr };
void _handle_io_progress() void _handle_io_progress()
{ {
@ -126,14 +117,6 @@ class Genode::Entrypoint : Noncopyable
_io_progress_handler->handle_io_progress(); _io_progress_handler->handle_io_progress();
} }
void _execute_post_signal_hook()
{
if (_post_signal_hook != nullptr)
_post_signal_hook->function();
_post_signal_hook = nullptr;
}
/* /*
* This signal handler is solely used to force an iteration of the * This signal handler is solely used to force an iteration of the
* signal-dispatch loop. It is triggered by 'schedule_suspend' to * signal-dispatch loop. It is triggered by 'schedule_suspend' to
@ -259,17 +242,6 @@ class Genode::Entrypoint : Noncopyable
} }
_io_progress_handler = &handler; _io_progress_handler = &handler;
} }
/**
* Register hook functor to be called after signal was handled
*
* \deprecated
* \noapi
*/
void schedule_post_signal_hook(Post_signal_hook *hook)
{
_post_signal_hook = hook;
}
}; };
#endif /* _INCLUDE__BASE__ENTRYPOINT_H_ */ #endif /* _INCLUDE__BASE__ENTRYPOINT_H_ */

4
repos/base/src/lib/base/entrypoint.cc
View File

@ -59,9 +59,6 @@ void Entrypoint::Signal_proxy_component::signal()
if (sig.context()->level() == Signal_context::Level::Io) { if (sig.context()->level() == Signal_context::Level::Io) {
/* trigger the progress handler */ /* trigger the progress handler */
io_progress = true; io_progress = true;
/* execute deprecated per-signal hook */
ep._execute_post_signal_hook();
} }
} catch (Signal_receiver::Signal_not_pending) { } } catch (Signal_receiver::Signal_not_pending) { }
@ -214,7 +211,6 @@ bool Entrypoint::_wait_and_dispatch_one_io_signal(bool const dont_block)
} }
_dispatch_signal(sig); _dispatch_signal(sig);
_execute_post_signal_hook();
break; break;
} catch (Signal_receiver::Signal_not_pending) { } catch (Signal_receiver::Signal_not_pending) {