`org-return-indent` is obsolete since 9.4, one should use `org-return` with
`indent` set to `t` instead – and I am not sure whether it will work if I rebind
`org-return` to some interactive lambda form. So let's try to not indentent
automatically anymore, maybe this is good enough?
This is the expected behavior, and also how `db/run-or-hide-shell` works. The
implementation is structured differently, though … because I reinvented the
implementation of `db/run-or-hide-eshell` instead of generalizing the one of
`db/run-or-hide-shell`. Ah, anyway …
This is instead of repeating the path again and again in the code. It's cleaner
this way, also easier to spot mistakes (see the now fixed definition for
`abbrev-file-name' …).
Providing a non-nil universal argument to `db/load-known-ssh-keys` now readds
all known SSH keys to the current SSH agent, irregardless of whether they are
already present or not.
This will allow to bind `db/org-add-link-to-other-item` with different initial
inputs to different keys to have often used selection directly at hand.
Setting the initial input is a bit tricky, though, because
`org-refile-get-location` does not allow to set it. Instead, we have to
temporarily overwrite `completing-read` with the corresponding parameter set
directly.
This is supposed to inhibit this warning:
```
Warning: Eager macro-expansion skipped due to cycle:
… => (load "db-utils.el") => (macroexpand-all (defalias 'db/sync-magit-repos-from-projectile …)) => (macroexpand (eval-when-compile …)) => (load "db-utils.el")
```
It should make calling this function also more robust.
Also updated the implementation to be more “dash-y”.
The values in the variable `org-time-stamp-formats` do not contain angle
brackets anymore. Using the function `org-time-stamp-format` is more robust
anyway and is also the official way to retrieve this format.
This is meant to mitigate an issue with table alignment when those tables are
results of source blocks, contain links in cells and are hidden (i.e., folded):
in those circumstances, the table alignment seems to be broken, because the cell
width does not take into account that links are shorter than their textual
representation.
I am not quite sure whether this is a bug in my configuration or a bug in Org
mode itself. The function to compute cell width is `org-string-width`, but
maybe this function does not get passed the correct input when tables are folded
and need to be aligned?
This is required by the regular expression in `org-agenda-show-clocking-issues`,
without this space, no consistency checking is done.
Also indent all other agenda views, for consistency.