c3d2/nix-config
c3d2
/
nix-config
24
7
Fork 3
Code Issues 12 Pull Requests 2 Releases Wiki Activity

Do not set any options by default in nixosModules.c3d2 #16

New Issue
Closed
opened 2022-01-15 15:46:50 +01:00 by ehmry · 3 comments
ehmry commented 2022-01-15 15:46:50 +01:00
Owner
Copy Link

The nixosModules.c3d2 is setting options by default, and I would prefer to be able to import the module without any side effects if none of the options it defines are set.

Also, the isInHq stuff could be moved to module thats sets configuration but not options.

https://gitea.c3d2.de/c3d2/nix-config/src/branch/master/lib/default.nix#L269

https://gitea.c3d2.de/c3d2/nix-config/src/branch/master/lib/default.nix#L274

https://gitea.c3d2.de/c3d2/nix-config/src/branch/master/lib/default.nix#L291

This option is incorrectly implemented and systemd constantly spams the journal with Failed to set timeout to 15s: Invalid argument.
https://gitea.c3d2.de/c3d2/nix-config/src/branch/master/lib/default.nix#L334

https://gitea.c3d2.de/c3d2/nix-config/src/branch/master/lib/default.nix#L339

The `nixosModules.c3d2` is setting options by default, and I would prefer to be able to import the module without any side effects if none of the options it defines are set. Also, the `isInHq` stuff could be moved to module thats sets configuration but not options. https://gitea.c3d2.de/c3d2/nix-config/src/branch/master/lib/default.nix#L269 https://gitea.c3d2.de/c3d2/nix-config/src/branch/master/lib/default.nix#L274 https://gitea.c3d2.de/c3d2/nix-config/src/branch/master/lib/default.nix#L291 This option is incorrectly implemented and systemd constantly spams the journal with `Failed to set timeout to 15s: Invalid argument`. https://gitea.c3d2.de/c3d2/nix-config/src/branch/master/lib/default.nix#L334 https://gitea.c3d2.de/c3d2/nix-config/src/branch/master/lib/default.nix#L339
sandro commented 2022-01-15 18:12:38 +01:00
Owner
Copy Link

The purpose of the module is to enable default options and things just by importing it which we want to have on everything in the hq. For example we want some default packages everywhere and also enable openssh everywhere with the keys for everyone. If there is anything specific you want to re-use we can extract that.

The logging should be disabled until it is fixed but since I cannot deploy right now there is no point when I change it.

The purpose of the module is to enable default options and things just by importing it which we want to have on everything in the hq. For example we want some default packages everywhere and also enable openssh everywhere with the keys for everyone. If there is anything specific you want to re-use we can extract that. The logging should be disabled until it is fixed but since I cannot deploy right now there is no point when I change it.
ehmry commented 2022-01-15 18:37:43 +01:00
Author
Owner
Copy Link

https://gitea.c3d2.de/c3d2/nix-config/compare/master...split

https://gitea.c3d2.de/c3d2/nix-config/compare/master...split
ehmry commented 2022-01-15 21:16:48 +01:00
Author
Owner
Copy Link

I split the two concerns at f066f4cb82.

I split the two concerns at f066f4cb82e78a70800c7474f2b2ea0c65fda69d.
ehmry closed this issue 2022-01-15 21:16:56 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
flake-update
gitea-actions-runner
nixos-23.11
ds-future
container/radius
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: c3d2/nix-config#16
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?